Skip to content

Meshgrid Fix For RandSmoothDeform#4941

Merged
wyli merged 10 commits into
Project-MONAI:devfrom
ericspod:meshgrid_xy
Aug 19, 2022
Merged

Meshgrid Fix For RandSmoothDeform#4941
wyli merged 10 commits into
Project-MONAI:devfrom
ericspod:meshgrid_xy

Conversation

@ericspod

Copy link
Copy Markdown
Member

Description

RandSmoothDeform was specifying it's coordinates in "xy" ordering but using meshgrid in "ij" ordering which produces transposed results. This fixes this by adding meshgrid_xy.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli

wyli commented Aug 19, 2022

Copy link
Copy Markdown
Contributor

/build

@wyli wyli enabled auto-merge (squash) August 19, 2022 13:38
@wyli wyli merged commit 4270cdf into Project-MONAI:dev Aug 19, 2022
@ericspod ericspod deleted the meshgrid_xy branch August 19, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants